docs: Fix broken NCCL test anchor links for GKE blueprints#6008
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses broken documentation links related to NCCL testing in various GKE blueprints. By redirecting these links to the updated, hardware-specific documentation pages, the changes ensure that users are directed to the correct resources for running NCCL tests on their respective cluster configurations. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the NCCL test documentation links across several GKE example README files. The review feedback recommends using the standard public domain 'cloud.google.com' instead of 'docs.cloud.google.com' to maintain consistency and prevent potential authentication or layout issues for external users.
|
@Grimreaper00025 Let's apply the gemini suggestions. |
8e2b321
into
GoogleCloudPlatform:develop
2 participants
Description
The NCCL test documentation link in
cloud.google.com/ai-hypercomputer/docs/create/gke-ai-hypercompute#deploy-run-nccl-tas-testis obsolete and leads to a broken or missing anchor tag on the generic page. The underlying Cloud Docs have been split into hardware-specific anchors onhttps://docs.cloud.google.com/ai-hypercomputer/docs/nccl/test-gke.While the
developbranch has already successfully updated this endpoint for the A3 Mega blueprint, the remaining blueprints were missed and were still routing to the dead/create/link.This PR aligns the remainder of the GKE blueprints to point sequentially to their new hardware-specific anchors in the
nccl/test-gkedocs (e.g.,#a3-ultra,#a4,#a4x).Affected Files
examples/gke-a3-ultragpu/README.mdexamples/gke-a4/README.mdexamples/gke-a4x/README.mdexamples/gke-consumption-options/dws-calendar.md